Skip to content

Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 1 | Form Controls#1353

Open
fromonda wants to merge 4 commits into
CodeYourFuture:mainfrom
fromonda:feature/form-controls
Open

Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 1 | Form Controls#1353
fromonda wants to merge 4 commits into
CodeYourFuture:mainfrom
fromonda:feature/form-controls

Conversation

@fromonda
Copy link
Copy Markdown

@fromonda fromonda commented May 25, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Created a form to collect customer details for a T-shirt order
  • Added a required name field with validation to ensure at least two non-space characters
  • Added a required email field with built-in email validation
  • Added a colour selection using radio buttons (Red, Blue, Green)
  • Restricted colour input so only predefined options can be selected
  • Added a size dropdown with 6 required options (XS to XXL)
  • Ensured all fields are required and validated before submission

@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit ea27a89
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a173ea29db9670008845a4a
😎 Deploy Preview https://deploy-preview-1353--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@fromonda fromonda changed the title Add T-shirt order form with validation Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 1 | Form Controls May 26, 2026
@fromonda fromonda added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 26, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 27, 2026

Can you format the "Changelist" section of the PR description so that it looks like this:

Changelist

  • Created a form to collect customer details for a T-shirt order
  • Added a required name field with validation to ensure at least two non-space characters
  • Added a required email field with built-in email validation
  • Added a colour selection using radio buttons (Red, Blue, Green)
  • Restricted colour input so only predefined options can be selected
  • Added a size dropdown with 6 required options (XS to XXL)
  • Ensured all fields are required and validated before submission

cjyuan
cjyuan reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Form looks good.

  • Could you improve the Lighthouse Accessibility score (as reported by the browser's Lighthouse dev tool) to 100?
Image

  • Can you add a submit button so that we could use it to test the form?

  • Your code is well formatted.

    If you haven't yet enabled "Format on save" on VS Code, please take a look at this guide. In long run, it could save you a lot of time.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 27, 2026
@fromonda fromonda added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fromonda @cjyuan